Fixes of newer MediaWiki and SMW versions #124
Conversation
DanielWTQ
force-pushed
the
fixes
branch
2 times, most recently
from
013b35f to
d718e76
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
============================================
- Coverage 10.69% 10.61% -0.09%
Complexity 429 429
============================================
Files 22 22
Lines 1683 1724 +41
============================================
+ Hits 180 183 +3
- Misses 1503 1541 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace SMW aliases that were removed in SMW 5, replace use of wfGetDB(), add missing `__METHOD__` to database calls, avoid writing directly to `$wgHooks`, and other cleanup.
|
Thanks for fixing CI in #125 |
| } | ||
|
|
||
| function rewind() { | ||
| function rewind(): void { |
There was a problem hiding this comment.
Is the type declaration intentional? If so, what's the reasoning behind adding them specifically to these functions? I'm curious about the decision-making process for including them.
There was a problem hiding this comment.
Compatibility with the iterator interface, otherwise there are warnings
For next() I added #[\ReturnTypeWillChange] because the existing code doesn't match the return type that should be used for the interface, but for the other interface methods it already matched and so we could just add the return type
See https://wiki.php.net/rfc/internal_method_return_types and the docs at https://www.php.net/manual/en/class.iterator.php
|
@alistair3149 @paladox anything I can do to make this easier to review? (Not trying to nag, just want to make sure you aren't waiting for something more from me) |
|
array() should probably be changed to [] but that's a code style issue and can be done in another commit so this looks good to me. |
3 participants
Replace SMW aliases that were removed in SMW 5, replace use of wfGetDB(), add missing
__METHOD__to database calls, avoid writing directly to$wgHooks, and other cleanup