Skip to content

Conversation

@DanielWTQ
Copy link
Contributor

@DanielWTQ DanielWTQ commented Dec 2, 2025

Method was removed from the database class, call the ResultWrapper method

See T286694 for context

Method was removed from the database class, call the ResultWrapper method

See T286694 for context
@DanielWTQ
Copy link
Contributor Author

I couldn't get automated testing to confirm that this is needed, but manual testing shows that groups with edits couldn't be deleted:

{
    "error": {
        "code": "internal_api_error_Error",
        "info": "[804f2272eac3d1d41284f917] Exception caught: Call to undefined method Wikimedia\\Rdbms\\DatabaseMySQL::numRows()",
        "errorclass": "Error",
        "trace": "Error at /var/www/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(127)\nfrom /var/www/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(127)\n#0 /var/www/mediawiki/w/extensions/SemanticWatchlist/src/Api/DeleteWatchlistGroup.php(140): Wikimedia\\Rdbms\\DBConnRef->__call()\n#1 /var/www/mediawiki/w/extensions/SemanticWatchlist/src/Api/DeleteWatchlistGroup.php(46): SWL\\Api\\DeleteWatchlistGroup->deleteGroup()\n#2 /var/www/mediawiki/w/includes/api/ApiMain.php(1974): SWL\\Api\\DeleteWatchlistGroup->execute()\n#3 /var/www/mediawiki/w/includes/api/ApiMain.php(942): MediaWiki\\Api\\ApiMain->executeAction()\n#4 /var/www/mediawiki/w/includes/api/ApiMain.php(913): MediaWiki\\Api\\ApiMain->executeActionWithErrorHandling()\n#5 /var/www/mediawiki/w/includes/api/ApiEntryPoint.php(153): MediaWiki\\Api\\ApiMain->execute()\n#6 /var/www/mediawiki/w/includes/MediaWikiEntryPoint.php(200): MediaWiki\\Api\\ApiEntryPoint->execute()\n#7 /var/www/mediawiki/w/api.php(44): MediaWiki\\MediaWikiEntryPoint->run()\n#8 {main}"
    }
}

formatted trace:

Error at /var/www/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(127)
from /var/www/mediawiki/w/includes/libs/rdbms/database/DBConnRef.php(127)
#0 /var/www/mediawiki/w/extensions/SemanticWatchlist/src/Api/DeleteWatchlistGroup.php(140): Wikimedia\\Rdbms\\DBConnRef->__call()
#1 /var/www/mediawiki/w/extensions/SemanticWatchlist/src/Api/DeleteWatchlistGroup.php(46): SWL\\Api\\DeleteWatchlistGroup->deleteGroup()
#2 /var/www/mediawiki/w/includes/api/ApiMain.php(1974): SWL\\Api\\DeleteWatchlistGroup->execute()
#3 /var/www/mediawiki/w/includes/api/ApiMain.php(942): MediaWiki\\Api\\ApiMain->executeAction()
#4 /var/www/mediawiki/w/includes/api/ApiMain.php(913): MediaWiki\\Api\\ApiMain->executeActionWithErrorHandling()
#5 /var/www/mediawiki/w/includes/api/ApiEntryPoint.php(153): MediaWiki\\Api\\ApiMain->execute()
#6 /var/www/mediawiki/w/includes/MediaWikiEntryPoint.php(200): MediaWiki\\Api\\ApiEntryPoint->execute()
#7 /var/www/mediawiki/w/api.php(44): MediaWiki\\MediaWikiEntryPoint->run()
#8 {main}

Probably would have been caught by phan if this extension used that

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 10.61%. Comparing base (6e20d42) to head (6d537fe).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Api/DeleteWatchlistGroup.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #127   +/-   ##
=========================================
  Coverage     10.61%   10.61%           
  Complexity      429      429           
=========================================
  Files            22       22           
  Lines          1724     1724           
=========================================
  Hits            183      183           
  Misses         1541     1541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vedmaka vedmaka self-requested a review December 5, 2025 00:23
@vedmaka vedmaka merged commit 6303977 into SemanticMediaWiki:master Dec 5, 2025
6 of 7 checks passed
@DanielWTQ DanielWTQ deleted the api-delete-fix branch December 5, 2025 20:19
DanielWTQ added a commit to WikiTeq/Taqasta that referenced this pull request Dec 5, 2025
Includes SemanticMediaWiki/SemanticWatchlist#127 to fix the api for deleting
watchlist groups

DEMO-137
DanielWTQ added a commit to WikiTeq/Taqasta that referenced this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants