-
-
Notifications
You must be signed in to change notification settings - Fork 10
DeleteWatchlistGroup: fix numRows() method call #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Method was removed from the database class, call the ResultWrapper method See T286694 for context
|
I couldn't get automated testing to confirm that this is needed, but manual testing shows that groups with edits couldn't be deleted: formatted trace: Probably would have been caught by phan if this extension used that |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 10.61% 10.61%
Complexity 429 429
=========================================
Files 22 22
Lines 1724 1724
=========================================
Hits 183 183
Misses 1541 1541 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Includes SemanticMediaWiki/SemanticWatchlist#127 to fix the api for deleting watchlist groups DEMO-137
#340) Includes SemanticMediaWiki/SemanticWatchlist#127 to fix the api for deleting watchlist groups DEMO-137
Method was removed from the database class, call the ResultWrapper method
See T286694 for context