Fix CI/CD failures and add CI workflow#3
Conversation
- Fix syntax errors and unused imports in `clients/portable/main.go`. - Fix encryption logic in `clients/portable/main.go` to match C++ backend. - Create `.github/workflows/ci.yml` to run build and test on PRs. - Update `.github/workflows/release.yml` to install Go and run tests. - Update `.gitignore` to ignore `wininspect-portable` binary. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add `.github/workflows/ci.yml` for per-PR testing. - Update `.github/workflows/release.yml` to include Go and tests. - Fix Go client: syntax errors, unused imports, encryption logic. - Fix C++ Core: missing includes in `win32_backend.cpp`. - Fix C++ Core: `BCryptBufferDesc` casing and missing `BCRYPT_ECD_PUBLIC_GENERIC_MAGIC` definition in `crypto.cpp`. - Update `.gitignore` to exclude `wininspect-portable` binary. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
- Add `.github/workflows/ci.yml` for per-PR testing. - Update `.github/workflows/release.yml` to include Go and tests. - Fix Go client: syntax errors, unused imports, encryption logic. - Fix CLI client: define `Conn` struct, fix syntax errors. - Fix GUI client: fix string escaping for JSON and pipe name. - Fix Daemon: fix `MessageBoxW` args, multiline string constant, add missing includes/helpers in `tcp_server.cpp`. - Fix C++ Core: missing includes/defines in `win32_backend.cpp` and `crypto.cpp`. - Update `.gitignore` to exclude `wininspect-portable` binary. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
- Add `.github/workflows/ci.yml` for per-PR testing. - Update `.github/workflows/release.yml` to include Go and tests. - Fix Go client: syntax errors, unused imports, encryption logic. - Fix CLI client: define `Conn` struct, fix syntax errors. - Fix GUI client: fix string escaping for JSON and pipe name. - Fix Daemon: fix `MessageBoxW` args, multiline string constant, add missing includes/helpers in `tcp_server.cpp`. - Fix Daemon Server: fix undeclared identifiers `auth_keys_u8`, `read_only`. - Fix C++ Core: missing includes (`<algorithm>`, `<iterator>`, `<wincrypt.h>`) and fixed `BCryptBufferDesc` usage. - Add `UNICODE` definition in `CMakeLists.txt` to fix `LVITEMW` type mismatch. - Update `.gitignore` to exclude `wininspect-portable` binary. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
@jules revise this PR for the current version on main. |
I have merged the latest changes from main and resolved conflicts while preserving the necessary fixes for CI. |
- Merged upstream main. - Resolved conflicts in `clients/gui/src/gui_main.cpp`, `clients/portable/main.go`, `core/src/crypto.cpp`, `core/src/win32_backend.cpp`, `daemon/src/server.cpp`, `daemon/src/tcp_server.cpp`, `daemon/src/tray.cpp`. - Preserved fixes for string escaping, includes, and logic errors. - Preserved upstream changes (UI Automation support in win32_backend). - Ensured UNICODE is defined for Windows builds. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
@jules update the pr so it merges properly |
Merged changes from |
- Merged upstream master (UIA survey tools, etc.) - Resolved conflicts in: - clients/gui/src/gui_main.cpp - clients/portable/main.go - core/src/crypto.cpp - core/src/win32_backend.cpp - daemon/src/server.cpp - daemon/src/tcp_server.cpp - daemon/src/tray.cpp - Preserved CI fixes (compilation, logic, syntax) while keeping upstream changes. - Verified local build. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
@jules I'm still seeing conflicts in this PR. revise this PR for the current version on main. |
I have resolved the remaining merge conflicts in |
- Resolved conflict in `clients/gui/src/gui_main.cpp`. - Preserved fixes for string escaping, includes, and logic errors. - Verified build. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
@jules examing the CI/CD logs and diagnose the failure. |
I have examined the CI/CD failures and codebase. The merge conflicts in |
- Merged master to resolve conflicts. - Resolved conflicts in `clients/gui/src/gui_main.cpp`. - Verified build with `tools/wbab build`. - Preserved CI fixes (UNICODE definition, string escaping, missing includes). - Preserved upstream changes (UIA tools). Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
|
@jules is this pr still relevant? |
Yes, this PR is still relevant. It contains necessary fixes for the CI/CD pipeline and resolves build failures that are present in the current codebase. |
- Merged master to resolve conflicts. - Resolved conflicts in `clients/gui/src/gui_main.cpp`. - Verified build with `tools/wbab build`. - Preserved CI fixes (UNICODE definition, string escaping, missing includes). - Preserved upstream changes (UIA tools). Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
- Enable recursive submodules in CI/Release workflows. - Fix `tools/wbab` to check for submodule script existence. - Merged upstream main and resolved conflicts. - Applied compilation/syntax fixes for C++ and Go clients. - Ensured UNICODE definition for Windows builds. Co-authored-by: mark-e-deyoung <1854350+mark-e-deyoung@users.noreply.github.com>
1 participant
This PR addresses CI/CD failures by fixing the Go portable client build, which was failing due to syntax errors. It also introduces a new CI workflow to run tests on every push and pull request, and updates the release workflow to ensure Go is installed and tests are run.
Changes:
clients/portable/main.go: Fixed syntax errors (newlines in strings), removed unused imports, and corrected the encryption logic to match the C++ backend format..github/workflows/ci.yml: Added a new workflow to runwbab buildandwbab teston Windows..github/workflows/release.yml: Addedactions/setup-goandwbab teststep..gitignore: Addedwininspect-portable.PR created automatically by Jules for task 6233513389955488526 started by @mark-e-deyoung