Merged
Conversation
+ TypeScript error fixes
Codecov Report
@@ Coverage Diff @@
## develop #603 +/- ##
===========================================
+ Coverage 91.56% 91.58% +0.02%
===========================================
Files 198 198
Lines 5403 5404 +1
Branches 1377 1376 -1
===========================================
+ Hits 4947 4949 +2
+ Misses 456 455 -1
Continue to review full report at Codecov.
|
fieldsToDisplay is a required field. It makes no sense to show null if it is undefined.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some annoying console errors when tests run. Also fixed typescript errors in tests.
There are still 2 more console warning about components not compatible with React 16.9.
react-quillandreact-autosuggestreact-autosuggest warning moroshko/react-autosuggest#681 (comment) is going to go away once released.
react-quill is waiting for zenoamaro/react-quill#549. It might not get merged anytime soon.