feat: migrate plugins from require to dynamic imports#147
Open
filiphsps wants to merge 3 commits intoSerenityJS:mainfrom
Open
feat: migrate plugins from require to dynamic imports#147filiphsps wants to merge 3 commits intoSerenityJS:mainfrom
require to dynamic imports#147filiphsps wants to merge 3 commits intoSerenityJS:mainfrom
Conversation
filiphsps
commented
May 3, 2025
filiphsps
force-pushed
the
dev/dynamic-imports
branch
from
6b392ac to
8ae4202
Compare
filiphsps
force-pushed
the
dev/dynamic-imports
branch
from
8ae4202 to
2d1bf0e
Compare
filiphsps
force-pushed
the
dev/dynamic-imports
branch
from
ee84225 to
42d7fd6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require an update to https://github.com/SerenityJS/server-binaries/blob/main/src/index.ts
Technically you could now replace more of the sync file operations with proper async ones to speed up plugin loading a bit but I leave that as an exercise for the reader.