Conversation
Queue -> rk3
Algorithm ->rk3
Vinograduss
reviewed
Dec 27, 2019
| Point EndPoint; | ||
| int UserID; | ||
| DataIn() {} | ||
| DataIn(::Filters _f, unsigned _t, unsigned _md, Point _sp, Point _ep, |
Collaborator
There was a problem hiding this comment.
значения должны передаваться в функцию по значению
именовать переменный через нижнее подчеркивание - плохой стиль. Такое именование используется в системных библиотеках для приватных членов
| assert(edges.size() == weights.size()); | ||
|
|
||
| edgeSize = edges.size(); | ||
| edgeArr = new edge[edgeSize]; |
Collaborator
There was a problem hiding this comment.
вместо сырых указателей в классе стоит использовать умные указатели
| weightArr = new weight[edgeSize]; | ||
| for (size_t i = 0; i < edgeSize; i++) { | ||
| *(edgeArr+i) = edges.at(i); | ||
| *(weightArr+i)= weights.at(i); |
Collaborator
There was a problem hiding this comment.
для преобразования вектора в сырой указатель стоит использовать метод .data() у вектора
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.