Bugfix - Type resolve missing for nested pages in structure#227
Merged
JanSlabon merged 2 commits intoSetasign:masterfrom Jan 15, 2025
Merged
Bugfix - Type resolve missing for nested pages in structure#227JanSlabon merged 2 commits intoSetasign:masterfrom
JanSlabon merged 2 commits intoSetasign:masterfrom
Conversation
Member
|
Great catch and I really wonder why this issue was not triggered before. Can you share the PDF in question? There's already a test document for a name tree: ...but yours seems to be structured differently. |
Contributor
Author
Hello, Example of PHP code causing an error<?php
use setasign\Fpdi\Fpdi;
require_once('fpdf/fpdf.php');
require_once('fpdi/src/autoload.php');
class Pdf {
function generatePreview($file)
{
$pdf = new FPDI();
$pdf_handle = fopen($file, 'rb');
$pageCount = $pdf->setSourceFile($pdf_handle);
$max = min(5, $pageCount);
for ($i=1; $i <= $max; $i++)
{
// Add page to the document
$templateID = $pdf->importPage($i);
$pdf->addPage();
$pdf->useTemplate($templateID);
}
$pdf_content = $pdf->Output('S');
header("Content-type:application/pdf");
echo $pdf_content;
fclose($pdf_handle);
return;
}
}
$pdf = new Pdf();
$pdf->generatePreview("PDF-complex-structure.pdf");I hope I've contributed to the growth of this wonderful library! 😊 |
Member
|
Thanks! This test document is really a very great example of how not to create a page tree 😂👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a bug in the code when working with PDF files that have a complex nested page structure.
Screenshot of an example structure
Which caused the following error:
Fatal error: Uncaught exception 'setasign\Fpdi\PdfParser\Type\PdfTypeException' with message 'Array value expected.'The proposed commit fixes this bug.