feat(Source Device): add async implementation #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowApex
force-pushed
the
shadowapex/async-source-device
branch
4 times, most recently
from
c5256fa to
d077be3
Compare
ShadowApex
force-pushed
the
shadowapex/async-source-device
branch
from
d077be3 to
ee01d4b
Compare
ShadowApex
force-pushed
the
shadowapex/async-source-device
branch
3 times, most recently
from
d26d35e to
54152d6
Compare
ShadowApex
force-pushed
the
shadowapex/async-source-device
branch
from
54152d6 to
2df1cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors source devices to so they can be implemented asynchronously.
Important
Since this change is a decently sized refactor, extensive testing should be completed before this is merged in.
With this change, we can move towards using
io_uringorepollbased event processing instead of spawning a thread per source device and sleeping for a specific polling interval. This change should, theoretically, provide lower latency and processing if events are processed in this way and use a single thread per composite device. Testing and benchmarking are required to confirm this.