Open
Conversation
Contributor
|
There are bashisms here, particularly ==, the POSIX standard is =. Makes sense to change to |
signalno11
suggested changes
Dec 12, 2024
Contributor
signalno11
left a comment
signalno11
left a comment
There was a problem hiding this comment.
Change == to =, otherwise, LGTM
signalno11
suggested changes
Dec 13, 2024
signalno11
suggested changes
Dec 13, 2024
Contributor
signalno11
left a comment
signalno11
left a comment
There was a problem hiding this comment.
Apart from this, LGTM
- more lax shebang - actually check for perl/mono/ffmpeg at start instead of just printing - set and recall command+flags for md5 checker (dedup) - set and recall tools dir, using symlinks so it's all in one place - also set executable bit in the repo's metadata for everything - remove call to `clear` from ncurses (there's a correct way, but why)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clearfrom ncurses (there's a correct way, but why)...and after all that, it's still not working :( Themagically works nowarmipscall is meant to createbuild/rh-eng.gbaright?