Conversation
ShamilovR
commented
Dec 30, 2024
| @allure.description('Проверяем ручку "Логин курьера в системе"') | ||
| class TestCheckLoginCourier: | ||
|
|
||
| @allure.step('Создаем и регистрируем всегда разных курьеров, и пробуем зайти в систему под его логином и паролем. Ожидаем успех == 200') |
Owner
Author
There was a problem hiding this comment.
Нужно исправить: здесь и далее: для читаемого отображения отчетов над каждым тестом необходимо ставить декоратор title.
ShamilovR
commented
Dec 30, 2024
| "login": generate_random_string(10), | ||
| "password": generate_random_string(10) | ||
| } | ||
| response = requests.post(post_courier, data=payload) |
Owner
Author
There was a problem hiding this comment.
Можно лучше: данный функционал относится к предусловиям, а предусловия принято выносить в фикстуры для удобства переиспользования.
ShamilovR
commented
Dec 30, 2024
| "password": "" | ||
| } | ||
| response = requests.post(login_courier, payload) | ||
| assert response.json() == {"code": 400, "message": "Недостаточно данных для входа"} and response.status_code == 400 |
Owner
Author
There was a problem hiding this comment.
Можно лучше: здесь и далее: тексты ответов на вопросы следует выносить в дата модули. В случае изменении текста ответа от сервера, не придется править в каждом тесте отдельно. Достаточно будет поправить лишь в одном месте - дата модуле.
ShamilovR
commented
Dec 30, 2024
| "firstName": generate_random_string(10) | ||
| } | ||
| response = requests.post(post_courier, data=payload) | ||
| assert response.status_code == 201 |
Owner
Author
There was a problem hiding this comment.
Нужно исправить: проверки лишь статуса кода недостаточно. Необходимо также парсить ответ.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.