Skip to content

DEV-701 sd logging data not seen with usbx msc log and stream#96

Open
s-varna wants to merge 41 commits intomainfrom
DEV-701_sdLogging_data_not_seen_with_usbx_msc_log_and_stream
Open

DEV-701 sd logging data not seen with usbx msc log and stream#96
s-varna wants to merge 41 commits intomainfrom
DEV-701_sdLogging_data_not_seen_with_usbx_msc_log_and_stream

Conversation

@s-varna
Copy link
Copy Markdown
Contributor

@s-varna s-varna commented Apr 7, 2026

No description provided.

s-varna and others added 2 commits April 3, 2026 17:43
sdlogging data was not seen when usb was plugged in and there was
sdlogging alredy in progress.

issue is handling with sdcard with usbx and mcu
usbx was not able to detect correct sdcard address
@s-varna s-varna requested review from Copilot and marknolan April 7, 2026 07:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an issue where SD logging data is not observed when using USBX MSC in a “log and stream” workflow, by adjusting when dock/USB setup logic runs and by refining SD-card handoff behavior when USB is plugged in.

Changes:

  • Removed LogAndStream_setupDockUndock() from the TASK_USB_SETUP execution path.
  • Added an SD “ready/transfer state” wait in LogAndStream_setupDock() before changing SD access routing.
  • When USB is plugged in (but not docked), explicitly routes SD access back to the MCU and invalidates DCache.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
TaskList/shimmer_taskList.c Stops invoking dock/undock setup from the USB setup task.
log_and_stream_common.c Adds SD readiness wait + USB-plug SD routing behavior; introduces DCache invalidation dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread log_and_stream_common.c Outdated
Comment thread log_and_stream_common.c Outdated
Comment thread log_and_stream_common.c Outdated
Base automatically changed from DEV-636_usbx_cdc_acm_msc_integration_changes to main April 13, 2026 14:29
marknolan and others added 22 commits April 14, 2026 16:35
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marknolan and others added 6 commits April 23, 2026 14:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.

Comments suppressed due to low confidence (1)

EEPROM/shimmer_eeprom.c:154

  • The docstring for ShimEeprom_checkBtErrorCounts() says it resets invalid counters and has a side effect calling ShimEeprom_resetBtErrorCounts(), but the function currently only returns 1/0 and does not reset anything. Either update the documentation or add the described reset behavior to match the comment.
/**
 * Checks if any Bluetooth error count fields are set to the invalid value
 * (0xFFFF). If so, resets all error counts to zero.
 *
 * @return 1 if any error count was invalid and reset, 0 otherwise.
 * @sideeffect Calls ShimEeprom_resetBtErrorCounts() if any count is invalid.
 */
uint8_t ShimEeprom_checkBtErrorCounts(void)
{
  if (eepromSensorSettingsPage.btCntDisconnectWhileStreaming == 0xFFFF
      || eepromSensorSettingsPage.btCntUnsolicitedReboot == 0xFFFF
      || eepromSensorSettingsPage.btCntRtsLockup == 0xFFFF
      || eepromSensorSettingsPage.btCntDataRateTestBlockage == 0xFFFF)
  {
    return 1;
  }
  return 0;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Platform/platform_api.c
Comment thread log_and_stream_common.c Outdated
Comment thread log_and_stream_definitions.h
Comment thread EEPROM/shimmer_eeprom.c Outdated
Comment thread log_and_stream_common.c Outdated
Comment thread Comms/shimmer_dock_usart.c
Comment thread Platform/platform_api.c
Comment thread log_and_stream_common.c
Comment thread TaskList/shimmer_taskList.c
Comment thread log_and_stream_common.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants