DEV-701 sd logging data not seen with usbx msc log and stream#96
Open
DEV-701 sd logging data not seen with usbx msc log and stream#96
Conversation
sdlogging data was not seen when usb was plugged in and there was sdlogging alredy in progress. issue is handling with sdcard with usbx and mcu usbx was not able to detect correct sdcard address
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where SD logging data is not observed when using USBX MSC in a “log and stream” workflow, by adjusting when dock/USB setup logic runs and by refining SD-card handoff behavior when USB is plugged in.
Changes:
- Removed
LogAndStream_setupDockUndock()from theTASK_USB_SETUPexecution path. - Added an SD “ready/transfer state” wait in
LogAndStream_setupDock()before changing SD access routing. - When USB is plugged in (but not docked), explicitly routes SD access back to the MCU and invalidates DCache.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| TaskList/shimmer_taskList.c | Stops invoking dock/undock setup from the USB setup task. |
| log_and_stream_common.c | Adds SD readiness wait + USB-plug SD routing behavior; introduces DCache invalidation dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adding co-pilot review comments
Base automatically changed from
DEV-636_usbx_cdc_acm_msc_integration_changes
to
main
April 13, 2026 14:29
…a_not_seen_with_usbx_MN
…//github.com/ShimmerResearch/log-and-stream-common.git into DEV-701_sdLogging_data_not_seen_with_usbx_MN
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
https://github.com/ShimmerResearch/log-and-stream-common.git into DEV-716_Save_BT_details_to_eeprom Conflicts: EEPROM/shimmer_eeprom.c
…o_eeprom DEV-716 fix for saving bt baud in correct format to eeprom
…t_seen_with_usbx_MN DEV-701 DEV-314 merging dock/usb handling pathways
…a_not_seen_with_usbx_msc_log_and_stream
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (1)
EEPROM/shimmer_eeprom.c:154
- The docstring for
ShimEeprom_checkBtErrorCounts()says it resets invalid counters and has a side effect callingShimEeprom_resetBtErrorCounts(), but the function currently only returns 1/0 and does not reset anything. Either update the documentation or add the described reset behavior to match the comment.
/**
* Checks if any Bluetooth error count fields are set to the invalid value
* (0xFFFF). If so, resets all error counts to zero.
*
* @return 1 if any error count was invalid and reset, 0 otherwise.
* @sideeffect Calls ShimEeprom_resetBtErrorCounts() if any count is invalid.
*/
uint8_t ShimEeprom_checkBtErrorCounts(void)
{
if (eepromSensorSettingsPage.btCntDisconnectWhileStreaming == 0xFFFF
|| eepromSensorSettingsPage.btCntUnsolicitedReboot == 0xFFFF
|| eepromSensorSettingsPage.btCntRtsLockup == 0xFFFF
|| eepromSensorSettingsPage.btCntDataRateTestBlockage == 0xFFFF)
{
return 1;
}
return 0;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tream' of https://github.com/ShimmerResearch/log-and-stream-common.git into DEV-701_sdLogging_data_not_seen_with_usbx_msc_log_and_stream
…tream' of https://github.com/ShimmerResearch/log-and-stream-common.git into DEV-701_sdLogging_data_not_seen_with_usbx_msc_log_and_stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.