Factor out compute_performance_metrics#34
Open
ahill187 wants to merge 77 commits intoShobiStassen:masterfrom
Open
Factor out compute_performance_metrics#34ahill187 wants to merge 77 commits intoShobiStassen:masterfrom
compute_performance_metrics#34ahill187 wants to merge 77 commits intoShobiStassen:masterfrom
Conversation
Fix simplicial set embedding bug
Add logging
Code cleanup
`func_mode` -> `get_mode`
Rename variables
Add docstrings and properties to the constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have factored out the function
compute_performance_metrics, sincerun_subPARCis redundant. I've then mergedrun_PARCandrun_subPARC.