Skip to content

Move run_umap_hnsw into its own file#52

Open
ahill187 wants to merge 218 commits intoShobiStassen:masterfrom
ahill187:umap
Open

Move run_umap_hnsw into its own file#52
ahill187 wants to merge 218 commits intoShobiStassen:masterfrom
ahill187:umap

Conversation

@ahill187
Copy link
Contributor

@ahill187 ahill187 commented Nov 15, 2024

Description

The function run_umap_hnsw doesn't really have anything to do with the PARC class; this is an example of a poorly connected class. I have put it into a separate file.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (updated docstrings or README files)
  • Tests (added new tests or modified current test suite)
  • Refactoring (changes in the design of the code that don't change the functionality)

Linked PRs / Issues

ahill187#30

Checklist:

  • I have performed a self-review of my code
  • I have documented my code with appropriate docstrings
  • I have made corresponding changes to the documentation / README files
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant