Build with Go 1.11#2
Merged
vvuibert merged 1 commit intoShopify:masterfrom Oct 30, 2018
bai:go111
Merged
Conversation
sam-obeid
reviewed
Oct 26, 2018
| - go test --timeout 5s -v -race ./... # Run all the tests with the race detector enabled | ||
| - ./testAndCover.sh # Run the tests again to get coverage info | ||
| - go vet ./... # go vet is the official Go static analyzer | ||
| - go vet -composites=false ./... # go vet is the official Go static analyzer |
Collaborator
Author
There was a problem hiding this comment.
because the tests at linkedin were failing linkedin#450
I can't remember exactly the error message
kidpollo
pushed a commit
that referenced
this pull request
May 14, 2025
Ignore ZooKeeper znode Create if the path already exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go
1.11