Skip to content

Update redirect logic in theme.liquid to support query params in the storefront_hostname config property #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calirvine merged 1 commit into from
Oct 14, 2025
Merged

Update redirect logic in theme.liquid to support query params in the storefront_hostname config property #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 14 additions & 8 deletions layout/theme.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,19 @@
window.location.pathname !== '/throttle/queue' &&
window.location.pathname !== '/challenge'
) {
var currentHostname = window.location.hostname;
var storefrontHostname = "{{ settings.storefront_hostname }}";
var currentUrl = new URL(window.location.href);
var storefrontConfigHostname = "{{ settings.storefront_hostname }}";
var storefrontUrl = new URL(
storefrontConfigHostname.startsWith('http') ? storefrontConfigHostname : `https://${storefrontConfigHostname}`
);

if (currentHostname !== storefrontHostname) {
var redirectUrl = window.location.href.replace(currentHostname, storefrontHostname);
if (currentUrl.hostname !== storefrontUrl.hostname) {
var redirectUrl = new URL(currentUrl);
redirectUrl.hostname = storefrontUrl.hostname;
// Merge search params from both currentUrl and storefrontUrl
storefrontUrl.searchParams.forEach(function(value, key) {
redirectUrl.searchParams.append(key, value);
});

var customRedirectsStr = "{{ settings.custom_redirects | newline_to_br | strip_newlines | replace: ' ', '' }}";
if (customRedirectsStr) {
Expand All @@ -62,15 +70,13 @@
var fromPath = redirect[0];
var toPath = redirect[1];

if (fromPath && toPath && redirectUrl.startsWith('https://' + storefrontHostname + fromPath)) {
redirectUrl = redirectUrl.replace(storefrontHostname + fromPath, storefrontHostname + toPath);
if (fromPath && toPath && redirectUrl.pathname.startsWith(fromPath)) {
redirectUrl.pathname = redirectUrl.pathname.replace(fromPath, toPath);
break;
}
}
}

redirectUrl = new URL(redirectUrl);

{%- if settings.integrate_with_customer_accounts and customer != null -%}
redirectUrl.searchParams.append('logged_in', 'true');

Expand Down