Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced? + WHAT is this pull request doing?
Applies the same changes as #3332, but onto 2024-10 branch.
We are doing this because the old cookies will stop working on May 1, 2026. This will break Shopify analytics for any merchants who haven't yet upgraded to a new Hydrogen version that works with the new cookies (while also being backwards compatible with the old cookies). Because May 1st is <365 days away, we are back-fixing past versions of Hydrogen so that all merchants using a Hydrogen version released in the last year will only have to do a minor version bump!
HOW to test your changes?
Run the e2e tests locally!
Post-merge steps
2024-10, we should get a PR automatically opened up on this branch by the back-fix workflowdocs/changelog.jsonwith upgrade instructions!Checklist