Allow to provide argument to delete the theme and update readme file for Theme acess token #100
Open
codal-nilayp wants to merge 2 commits intoShopify:mainfrom
Open
Allow to provide argument to delete the theme and update readme file for Theme acess token #100codal-nilayp wants to merge 2 commits intoShopify:mainfrom
codal-nilayp wants to merge 2 commits intoShopify:mainfrom
Conversation
|
fixes #99 Thanks! |
Author
|
@charlespwd ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers two main updates:
1. README update for theme access tokens
Updated the README to reflect the current Shopify flow. Since creating new legacy custom apps is no longer supported, the documentation now explains how to generate an access token using the Theme Access app instead.
2. Optional theme cleanup after report generation
Added a new configuration parameter, delete_theme_after_result, to optionally delete the theme created during the process.
This helps prevent hitting Shopify’s 100-theme limit.