Skip to content

Add highlight support for boolean expressions everywhere#54

Open
charlespwd wants to merge 1 commit intomainfrom
feature/boolean-expressions-everywhere
Open

Add highlight support for boolean expressions everywhere#54
charlespwd wants to merge 1 commit intomainfrom
feature/boolean-expressions-everywhere

Conversation

@charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Jan 12, 2026

In this PR

  • Groupings are now legal
  • Delete the invalid-range rule
  • Replace the range rule with just matching the ..

Fixes https://github.com/Shopify/developer-tools-team/issues/809

before after
tmp tmp

Testing:

Do it with Shopify/theme-tools#1100

(As well as parenthesized expressions)
@charlespwd charlespwd added the #gsd:48203 boolean expressions label Jan 12, 2026
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @charlespwd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:48203 boolean expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants