Fix compatibility with Rails edge #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following rails/rails#42649 we need to make some small changes to fix
with_local_store.Now ActiveSupport use the local store as a "payload" store (e.g. it contain serialized payloads instead of
Entryinstance). Both upstreamMemCacheStoreandMemcachedStoredon't play so well with this new architecture, because they directly passEntryinstance to the underlying client.So we basically need to backport the old local store behavior that was duping the cache entry to avoid leaks.
Longer term we should migrate to the new architecture where we no longer rely on
memcachedserializing objects for us (See: #63).