Enable Lint/EmptyBlock
#770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
github-actions
bot
added
the
config change
sambostock
approved these changes
Dec 1, 2025
Contributor
sambostock
left a comment
sambostock
left a comment
There was a problem hiding this comment.
Ironically, your example in the PR description would be allowed, because it contains a comment (but I think that is what we want, for cases where for some reason passing an empty block is required).
Member
|
I'm pretty sure I didn't enable this because of legit reasons. I need to run against our codebase to check. |
derik-thiessen
approved these changes
Dec 1, 2025
rafaelfranca
requested changes
Dec 3, 2025
Member
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
As I suspected, there are method that are today expected to use empty blocks, so we can't enable this rule.
One example is the on_mutation in graphql-easy-testing. You not always want to provide a block, but the library requires a block to be passed. So while we don't fix those requirement for empty blocks, being they legit or not, we can't enable this rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully a straight-forward proposal to enable
Lint/EmptyBlock, in an effort to prevent situations like this: