Skip to content

[Fix] Scopes constructor handle null parameter #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sarim wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix] Scopes constructor handle null parameter #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8702ec9
Scopes constructor handle null parameter
sarim Sep 26, 2023
8e2c751
Update CHANGELOG.md
sarim Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## Unreleased

- [#299](https://github.com/Shopify/shopify-api-php/pull/299) [Patch] Fix Scopes constructor to be able to handle null parameter
- [#297](https://github.com/Shopify/shopify-api-php/pull/297) [Patch] Fix CustomerAddress methods, FulfillmentRequest save method

## v5.1.0 - 2023-07-11
Expand Down
2 changes: 1 addition & 1 deletion src/Auth/Scopes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function __construct($scopes)
if (is_string($scopes)) {
$scopesArray = explode(self::SCOPE_DELIMITER, $scopes);
} else {
$scopesArray = $scopes;
$scopesArray = $scopes ?? [];
}

$scopesArray = array_unique(array_filter(array_map('trim', $scopesArray)));
Expand Down