Skip to content

feat: add rector base config #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shakaran wants to merge 2 commits into
base: main
Choose a base branch
from
+152 −2
Open

feat: add rector base config #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3edc399
feat: add rector base config
shakaran Apr 20, 2024
606ad11
fix: add composer normalization
shakaran Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"maglnet/composer-require-checker": "^3.0 || ^4.0",
"mikey179/vfsstream": "^1.6",
"phpunit/phpunit": "^9",
"rector/rector": "^1.0",
"squizlabs/php_codesniffer": "^3.6"
},
"suggest": {
Expand Down
121 changes: 119 additions & 2 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php
use Rector\Config\RectorConfig;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;

return RectorConfig::configure()
->withPaths([ __DIR__ . '/' ])
->withSkip([
Copy link
Contributor

@paulomarg paulomarg Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier to just point rector at src and tests, and ignore everything else? We shouldn't have any source files in other folders.

__DIR__ . '/.github',
__DIR__ . '/vendor',
__DIR__ . '/docs',
'rector.php',
'.gitignore',
'.git',
'CHANGELOG.md',
'composer.json',
'composer.lock',
'phpunit.xml',
'README.md',
'CONTRIBUTING.md',
'dev.yml',
'LICENSE',
'RELEASING.md',
'run_test_resource_test.sh',
'composer-require-checker.json'
])
->withRules([
ReadOnlyPropertyRector::class,
TypedPropertyFromStrictConstructorRector::class,
NullToStrictStringFuncCallArgRector::class
]);