[Fix] Fixed HMAC validation failure for query params with non url-safe characters #413
+28
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #412
When validating the hmac of a request, if some of the query params contain non url-safe characters, those are encoded, and the HMAC on our side is then computed based on that version. This differs from how the Shopify backend computes theirs, so the validation always fails
WHAT is this pull request doing?
Decode the query string before computing its HMAC for validation
Type of change
In practice, this will probably break downstreams, even though it's functionally a bugfix, so I'm marking it as a major change unless it's unnecessary.
Checklist