Use explicit type annotations for CurrentAttributes methods#2511
Merged
amomchilov merged 1 commit intoShopify:mainfrom Feb 17, 2026
Merged
Use explicit type annotations for CurrentAttributes methods#2511amomchilov merged 1 commit intoShopify:mainfrom
amomchilov merged 1 commit intoShopify:mainfrom
Conversation
When an explicit type is given for an attributes, e.g. by
attribute :user_id
#: -> Integer?
def user_id = super
we should use that type in the class methods rather than untyped.
amomchilov
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When an explicit type is given for an attributes, e.g. by
we should use that type in the class methods rather than untyped.
Implementation
Rather than grab the method from the class, use
instance_method()forboth the class and the GeneratedAttributesMethod signatures.
Tests
Yes.