Skip to content

Disable outdated rules from eslint-plugin-react #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xty wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable outdated rules from eslint-plugin-react #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wet-meals-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/eslint-plugin': patch
---

Disable outdated rules (react/{react-in-jsx-scope,jsx-uses-react})
4 changes: 2 additions & 2 deletions packages/eslint-plugin/lib/config/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ module.exports = {
// Prevent missing props validation in a React component definition
'react/prop-types': 'error',
// Prevent missing React when using JSX
'react/react-in-jsx-scope': 'error',
'react/react-in-jsx-scope': 'off',
// Enforce a defaultProps definition for every prop that is not a required prop
'react/require-default-props': 'off',
// Enforce React components to have a shouldComponentUpdate method
Expand Down Expand Up @@ -193,7 +193,7 @@ module.exports = {
// Validate whitespace in and around the JSX opening and closing brackets
'react/jsx-tag-spacing': 'error',
// Prevent React to be incorrectly marked as unused
'react/jsx-uses-react': 'error',
'react/jsx-uses-react': 'off',
// Prevent variables used in JSX to be incorrectly marked as unused
'react/jsx-uses-vars': 'error',
// Prevent missing parentheses around multilines JSX
Expand Down