Skip to content

Enable @typescript-eslint/consistent-type-imports #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tizmagik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable @typescript-eslint/consistent-type-imports #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fluffy-spoons-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/eslint-plugin': minor
---

Enable @typescript-eslint/consistent-type-imports to error
2 changes: 2 additions & 0 deletions packages/eslint-plugin/lib/config/typescript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ module.exports = {
'@typescript-eslint/ban-ts-comment': 'error',
// Enforce consistent brace style for blocks
'@typescript-eslint/brace-style': 'error',
// Enforce consistent type imports when importing a token as strictly a type vs as a runtime value
'@typescript-eslint/consistent-type-imports': 'error',
// Enforces consistent usage of type assertions.
'@typescript-eslint/consistent-type-assertions': [
'error',
Expand Down