Fix prefer-class-properties to ignore constructor overload declarations #408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When used in a Typescript codebase, where constructor overloads/multiple signatures are definable,
prefer-class-propertieswill throw an exception, as it currently assumes that there will only be one or zero constructor declarations in a class (which is true for JS, but not for TS).So the following results in an exception when executing ESLint
because
getConstructor()will find the empty constructor overload/signature first, and then subsequently fail when trying to access the body, which isnull.I've updated
getConstructor()to ignore constructors with no body, so that the "real" constructor is found and analysed.