Open
Conversation
… covers all the course topics, the game was simple yet followed all the criteria. Some of my changes that I made was that I made it so the questions would be shuffled and randomized everytime you start a new game as I felt that it allowed for replayability. I also added a pause timer button in order to pause the timer for those who would like the option to. Additionally, I made the window larger for better visibility. Further, I added it so that the player could see their score in real time. Some suggestions or TODO comments that I made was possibly having sound effects everytime there was a right or wrong answer. Obviously if you wanted them to not know then this isnt really needed. Also, I made some minor changes and fixes so that if you wanted to add on to the game, it would make it easier. Besides that, this was well done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, I thought that your code was really well made and because it covers all the course topics, the game was simple yet followed all the criteria.
Some of my changes that I made was that I made it so the questions would be shuffled and randomized everytime you start a new game as I felt that it allowed for replayability. I also added a pause timer button in order to pause the timer for those who would like the option to. Additionally, I made the window larger for better visibility. Further, I added it so that the player could see their score in real time.
Some suggestions or TODO comments that I made was possibly having sound effects everytime there was a right or wrong answer. Obviously if you wanted them to not know then this isnt really needed. Also, I made some minor changes and fixes so that if you wanted to add on to the game, it would make it easier. Besides that, this was well done.