fix(matrix): restore allowlist fallback for dm/group policies#3
Open
fix(matrix): restore allowlist fallback for dm/group policies#3
Conversation
Normalize Matrix monitor access policy resolution to honor legacy `dmPolicy`/`allowFrom` fields and reuse DM allowlists for group allowlist mode when group-specific entries are unset. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dm.policy+dm.allowFromand ignored legacydmPolicy/allowFromfields; group allowlist mode also did not fall back to DM allowlist whengroupAllowFromwas unset.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
dmPolicy/allowFromconfig.groupPolicy: allowlistnow correctly uses DM allowlist as fallback whengroupAllowFromis omitted.Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
bun test extensions/matrix/src/matrix/monitor/index.access-config.test.tspasses.dmPolicymapping and group allowlist fallback behavior.Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
extensions/matrix/src/matrix/monitor/index.ts.Risks and Mitigations