-
Notifications
You must be signed in to change notification settings - Fork 45.7k
fix: AI Text Generator Block prompt value handling #9896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix: AI Text Generator Block prompt value handling #9896
Conversation
…rent thread (Significant-Gravitas#9878) There are instances of node executions that were failed and end up stuck in the RUNNING status due to the execution failed to release the lock: ``` 2025-04-24 20:53:31,573 INFO [ExecutionManager|uid:25eba2d1-e9c1-44bc-88c7-43e0f4fbad5a|gid:01f8c315-c163-4dd1-a8a0-d396477c5a9f|nid:f8bf84ae-b1f0-4434-8f04-80f43852bc30]|geid:2e1b35c6-0d2f-4e97-adea-f6fe0d9965d0|neid:590b29ea-63ee-4e24-a429-de5a3e191e72|-] Failed node execution 590b29ea-63ee-4e24-a429-de5a3e191e72: Cannot release a lock that's no longer owned ``` ### Changes 🏗️ Check the ownership of the lock before releasing. ### Checklist 📋 #### For code changes: - [x] I have clearly listed my changes in the PR description - [x] I have made a test plan - [x] I have tested my changes according to the test plan: <!-- Put your test plan here: --> - [x] Existing CI tests. (cherry picked from commit ef02272)
This PR targets the Automatically setting the base branch to |
Here's the code health analysis summary for commits Analysis Summary
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for auto-gpt-docs-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Screen.Recording.2025-04-30.at.8.53.00.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still seeing behavior, see attached video
When using the AI Text Generator block, users were unable to create prompt values with similar names (e.g., 'PR-Title' and 'PR-Title-test') as the second value would be instantly removed. This restricted users from specifying prompt variables whose names overlap, which is important for thorough testing and differentiating prompt roles. The fix allows for more flexible naming while still preventing exact duplicates.
Changes 🏗️
NodeKeyValueInput
component to only check for exact duplicatesChecklist 📋
For code changes:
For configuration changes:
.env.example
is updated or already compatible with my changesdocker-compose.yml
is updated or already compatible with my changesFixes #9884