Skip to content

Comments

Use 'self' instead of 'cls' in validator methods following Python conventions#11

Open
Copilot wants to merge 10 commits intostu/add_ci_pipelinefrom
copilot/sub-pr-8-another-one
Open

Use 'self' instead of 'cls' in validator methods following Python conventions#11
Copilot wants to merge 10 commits intostu/add_ci_pipelinefrom
copilot/sub-pr-8-another-one

Conversation

Copy link

Copilot AI commented Jan 3, 2026

  • Understand the feedback about using 'self' instead of 'cls' in validator methods
  • Review the unified_validator decorator implementation
  • Determine the correct approach (modify decorator vs modify methods)
  • Update the unified_validator decorator to accept 'self' and transform to 'cls'
  • Update all validator methods to use 'self' instead of 'cls'
  • Test the changes to ensure validators still work correctly
  • Address code review feedback about metadata preservation
  • Remove unused imports
  • Improve code comments for clarity
  • Reply to the comment once changes are complete
  • Run security checks (CodeQL) - no vulnerabilities found
  • Final code review and validation
  • Rebase onto copilot/sub-pr-8 to resolve conflicts and maintain linear history

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 6 commits January 3, 2026 15:24
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
…fic InvalidVersion exception

Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
…hon conventions

Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Co-authored-by: stuartp44 <1926002+stuartp44@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on CI, publish, and release workflows Use 'self' instead of 'cls' in validator methods following Python conventions Jan 3, 2026
Copilot AI requested a review from stuartp44 January 3, 2026 15:36
@stuartp44
Copy link
Collaborator

@copilot can you fix the conflicts

Copy link
Author

Copilot AI commented Jan 7, 2026

@copilot can you fix the conflicts

Conflicts resolved by merging copilot/sub-pr-8 branch. The merge added validation for custom version input in the release workflow. (2afbb20)

@stuartp44
Copy link
Collaborator

@copilot more conflicts

Copy link
Author

Copilot AI commented Jan 8, 2026

@copilot more conflicts

I've checked the repository state thoroughly. The branch is currently up to date with copilot/sub-pr-8 (commit 930edb4) from the previous merge (2afbb20). No new conflicts detected - all files merge cleanly and tests pass. The GitHub UI conflict indicator may be stale. Could you provide more details about which files show conflicts?

@stuartp44
Copy link
Collaborator

@copilot models.py of which there is 9 conflicts

Copy link
Author

Copilot AI commented Jan 8, 2026

@copilot models.py of which there is 9 conflicts

Resolved the conflicts in models.py by rebasing the branch onto copilot/sub-pr-8. The branch now has a linear history with all validator methods correctly using 'self' instead of 'cls'. All tests pass. (5c193a7)

@stuartp44 stuartp44 marked this pull request as ready for review January 10, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants