Increase ACK timeout in test_serialapi#49
Merged
lmolina merged 1 commit intoSiliconLabs:mainfrom Mar 24, 2026
Merged
Conversation
lmolina
added a commit
to lmolina/zipgateway
that referenced
this pull request
Mar 23, 2026
Increase ACK timeout in the test harness so malformed-frame assertions validate parser behavior instead of failing due to slow tests execution due because of the host. This is most notably when the test rans in a Docker container that relies in QEMU to run an armv7 on amd64. Related-to: ZGW-3458 Origin: SiliconLabs#49 Signed-off-by: Laudin Molina Troconis <laudin.molinatroconis@silabs.com>
lmolina
force-pushed
the
bugfix/lamolina/test_serial_api/main
branch
from
7531689 to
b8e624e
Compare
lmolina
added a commit
to lmolina/zipgateway
that referenced
this pull request
Mar 24, 2026
Increase ACK timeout in the test harness so malformed-frame assertions validate parser behavior instead of failing due to slow tests execution due because of the host. This is most notably when the test rans in a Docker container that relies in QEMU to run an armv7 on amd64. Related-to: ZGW-3458 Origin: SiliconLabs#49 Signed-off-by: Laudin Molina Troconis <laudin.molinatroconis@silabs.com>
lmolina
force-pushed
the
bugfix/lamolina/test_serial_api/main
branch
from
b8e624e to
891b681
Compare
Increase ACK timeout in the test harness so malformed-frame assertions validate parser behavior instead of failing due to slow tests execution due because of the host. This is most notably when the test rans in a Docker container that relies in QEMU to run an armv7 on amd64. Related-to: ZGW-3458 Origin: SiliconLabs#49 Signed-off-by: Laudin Molina Troconis <laudin.molinatroconis@silabs.com>
lmolina
force-pushed
the
bugfix/lamolina/test_serial_api/main
branch
from
891b681 to
5d31770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_serialapiis flaky due to a to timeout that's too short when the host is "slow," e.g., a container using virtualization.