You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR replaces six NEW_ID calls (which generate file/line-based auto-indexed IDs) with NEW_ID2_SUFFIX(...) calls in pmux2shiftx.cc, giving the created wires and cells human-readable names derived from the parent $pmux cell name (e.g., <cell>_xor, <cell>_sub, <cell>_out). The cell variable from the outer loop is correctly in scope for all NEW_ID2_SUFFIX macro expansions, and module->uniquify() handles name deduplication across iterations.
Confidence Score: 5/5
Safe to merge — the change is a straightforward naming improvement with no logic or correctness risk.
All six substitutions use the correct macro (NEW_ID2_SUFFIX) that is well-defined for the current scope where cell is available, and module->uniquify() ensures no name collisions across loop iterations. No P0 or P1 issues found.
No files require special attention.
Important Files Changed
Filename
Overview
passes/opt/pmux2shiftx.cc
Six NEW_ID → NEW_ID2_SUFFIX replacements to produce descriptive names for generated wires/cells; macro is correctly in scope and uniquify handles deduplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dont use newname, use newname2