Skip to content

Pmux2shiftx#157

Merged
akashlevy merged 2 commits intomainfrom
pmux2shiftx
Apr 25, 2026
Merged

Pmux2shiftx#157
akashlevy merged 2 commits intomainfrom
pmux2shiftx

Conversation

@stanminlee
Copy link
Copy Markdown

dont use newname, use newname2

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 25, 2026

Greptile Summary

This PR replaces six NEW_ID calls (which generate file/line-based auto-indexed IDs) with NEW_ID2_SUFFIX(...) calls in pmux2shiftx.cc, giving the created wires and cells human-readable names derived from the parent $pmux cell name (e.g., <cell>_xor, <cell>_sub, <cell>_out). The cell variable from the outer loop is correctly in scope for all NEW_ID2_SUFFIX macro expansions, and module->uniquify() handles name deduplication across iterations.

Confidence Score: 5/5

Safe to merge — the change is a straightforward naming improvement with no logic or correctness risk.

All six substitutions use the correct macro (NEW_ID2_SUFFIX) that is well-defined for the current scope where cell is available, and module->uniquify() ensures no name collisions across loop iterations. No P0 or P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
passes/opt/pmux2shiftx.cc Six NEW_ID → NEW_ID2_SUFFIX replacements to produce descriptive names for generated wires/cells; macro is correctly in scope and uniquify handles deduplication.

Reviews (1): Last reviewed commit: "Merge branch 'main' of github.com:silima..." | Re-trigger Greptile

@akashlevy akashlevy merged commit b56104a into main Apr 25, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants