Skip to content

[CUS-515] - Add '-unignore_module' flag#158

Merged
akashlevy merged 6 commits intomainfrom
frontend-verific
Apr 29, 2026
Merged

[CUS-515] - Add '-unignore_module' flag#158
akashlevy merged 6 commits intomainfrom
frontend-verific

Conversation

@stanminlee
Copy link
Copy Markdown

Removes a module from verific parse tree and from ignore list if it is deleted.

Allows us to re-read a module definition (macro or simulation file)

@linear
Copy link
Copy Markdown

linear Bot commented Apr 28, 2026

CUS-515

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

Adds a -delete_module sub-command to the Verific frontend pass that removes one or more named modules from the Verific parse tree (veri_file::RemoveModule) and from the ignored-module set (GetIgnoredModuleSet()->Remove), allowing a module definition to be re-read after being deleted. The implementation includes an optional -work <lib> flag, consistent with other options in this pass.

Confidence Score: 4/5

Safe to merge; only P2 style findings with no logic or security issues.

All findings are P2 (style/consistency). No logic errors, data corruption, or security concerns were identified.

No files require special attention beyond the noted style fixes.

Important Files Changed

Filename Overview
frontends/verific/verific.cc Adds -delete_module sub-command to VerificPass::execute that removes named modules from the Verific parse tree and from the ignored-module set; minor style inconsistency in string lifetime and missing inline comment.

Sequence Diagram

sequenceDiagram
    participant User as Yosys Script
    participant VP as VerificPass::execute
    participant IgnSet as veri_file::IgnoredModuleSet
    participant PT as veri_file ParseTree

    User->>VP: verific -delete_module [-work lib] module...
    VP->>IgnSet: GetIgnoredModuleSet()
    IgnSet-->>VP: Set* (or null)
    loop for each module name
        VP->>IgnSet: Remove(name) [if set exists]
        VP->>PT: RemoveModule(name, lib)
    end
    VP-->>User: goto check_error (cleanup)
Loading

Reviews (1): Last reviewed commit: "delete module frontend" | Re-trigger Greptile

Comment thread frontends/verific/verific.cc Outdated
Comment thread frontends/verific/verific.cc Outdated
Comment thread frontends/verific/verific.cc Outdated
@stanminlee stanminlee changed the title [CUS-515] - Allow for deleting modules from verific frontend [CUS-515] - Add '-unignore_module' flag Apr 28, 2026
@akashlevy akashlevy merged commit 162233a into main Apr 29, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants