Open
Conversation
Added comments on logical issues that I noticed. Didn't change anything yet.
Fixed indentation and whitespace issues.
Updating Fork
Catch up
Fixed issue with calling gamePanel constructor. Changed Image folder into a source folder for use by program.
GUI works!
Working GUI
Merge pull request #3 from kchoadley/master
GUIWrapperPlayer now can return the player it contains. Needed for detecting winner when ComputerPlayer is checking possible moves. ComputerPlayer scoreMove revamped. Set better boundaries and condition when checking for a winning board. Uses about half as many loops.
Fixed Computer Logic
Ensures the player names are valid entries. Also fixed a defect I injected in detecting player column wins.
Validate user input
Validate User Input
Also fixed winning not detected on full board.
Fixed the game crashing on full board.
Fixed full board crash
Test cases for
Updating test cases to apply with new method rules
User can select easy, normal, or hard difficulty for computer AI. User name entry will now handle duplicate player names, too long of player name, or empty player names. Some minor code clean up.
Added "Brutal" Difficulty.
Now trims name input regardless of how it is entered to maximum length on entry.
Added .wav files and calls to play them
added GamePanel test cases
Implemented Enhancements
Edit test cases because GamePanel constructor has an added parameter (depth)
Removed full board defects.
Includes background music now - Volume still not fixed
Removed unnecessary gamePanel instantiation on creation of GUI.
Added static value to GUI.java and volume code to each sound function
Added music attribute and link to source
Adding sound, removing Jnario files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue with calling gamePanel constructor. Changed Image folder into a source folder for use by program.