Skip to content

Develop#38

Merged
albertomandlate merged 6 commits intorelease-v0.8.5from
develop
May 22, 2025
Merged

Develop#38
albertomandlate merged 6 commits intorelease-v0.8.5from
develop

Conversation

@albertomandlate
Copy link
Copy Markdown
Contributor

This pull request includes updates to the CodeQL workflow configuration and a minor adjustment in the Mozambique SAF-T generator. The most important changes involve expanding branch coverage for CodeQL analysis, translating workflow step names to Portuguese, and modifying XML writer settings for performance.

Updates to CodeQL workflow configuration:

  • .github/workflows/codeql.yml: Expanded branch coverage for triggering CodeQL analysis to include develop and release-** branches.
  • .github/workflows/codeql.yml: Translated workflow step names to Portuguese, including "Analyze" to "Analisar," "Initialize CodeQL" to "Inicializar o CodeQL," and "Perform CodeQL Analysis" to "Fazendo analises com o CodeQL." [1] [2] [3]

Adjustment in Mozambique SAF-T generator:

Mudou a propriedade `Indent` de `true` para `false` na configuração do `XmlWriterSettings`. Isso resulta em uma saída XML mais compacta, sem indentação.
Alterar configuração de indentação do XML
@albertomandlate albertomandlate requested a review from Copilot May 22, 2025 17:28
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands CodeQL analysis coverage to the develop and release-** branches with localized step names in Portuguese, and tweaks the Mozambique SAF-T generator for performance by disabling XML indentation.

  • Add develop and release-** branches to CodeQL triggers and translate workflow step names to Portuguese.
  • Change XmlWriterSettings.Indent to false in MozambiqueSaftGenerator to improve performance.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs Disable XML indentation (Indent = false) for potential performance gains.
.github/workflows/codeql.yml Include develop and release-** branches and translate step names to Portuguese.
Comments suppressed due to low confidence (2)

.github/workflows/codeql.yml:24

  • [nitpick] The workflow step names mix imperative and gerund forms (e.g., 'Analisar' vs. 'Fazendo analises com o CodeQL'). Consider using a consistent verb form, such as all infinitive commands or all gerunds, for better readability and consistency.
    - name: Analisar (${{ matrix.language }})

src/SAF-T.Mozambique/Generators/MozambiqueSaftGenerator.cs:261

  • [nitpick] Consider adding a comment explaining why indentation is disabled and any potential trade-offs (e.g., reduced readability vs. performance improvement).
                Indent = false,

@albertomandlate
Copy link
Copy Markdown
Contributor Author

This pull request includes updates to the CodeQL workflow configuration and a minor code adjustment in the Mozambique SAF-T generator. The most important changes include expanding branch coverage for CodeQL workflows, localizing workflow step names to Portuguese, and modifying XML writer settings to disable indentation.

Updates to CodeQL Workflow:

Changes in Mozambique SAF-T Generator:

@albertomandlate albertomandlate self-assigned this May 22, 2025
@albertomandlate albertomandlate merged commit 91b571e into release-v0.8.5 May 22, 2025
6 checks passed
@albertomandlate albertomandlate deleted the develop branch May 22, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants