Skip to content

[BUG FIX] [MER-4879] always set shuffle on ordering questions #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgachuhi merged 1 commit into from
Aug 27, 2025
Merged

[BUG FIX] [MER-4879] always set shuffle on ordering questions #286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/resources/formative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ function getHotspots(imageHotspot: any) {
}

function ordering(question: any) {
const shuffle = Common.getChild(question, 'ordering').shuffle;
const transformationElement = Common.getChild(question, 'transformation');
const transformationsArray =
transformationElement === undefined ? [] : [transformationElement];
Expand All @@ -309,7 +308,8 @@ function ordering(question: any) {
version: 2,
parts: [buildOrderingPart(question)],
transformations: [
...(shuffle === 'true' ? [Common.shuffleTransformation()] : []),
// no shuffle attribute, just always set on this question type
Common.shuffleTransformation(),
...transformationsArray,
],
previewText: '',
Expand Down Expand Up @@ -764,7 +764,6 @@ export class Formative extends Resource {
r.children[0].children,
this.file
);

resolve(items);
});
});
Expand Down
Loading