Conversation
…points per question
andersweinstein
changed the title
rgachuhi
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy instructor-graded pool questions for French carry custom point values via the score_out_of attribute, but these point values are not being preserved in migration. Instructor graded questions are the only questions that depend on this attribute for custom point values.
In addition, any custom points on pool questions are now overridden by the new pointsPerQuestion attribute on selection, which defaults to 1.
This updates the migration tool to do two things:
Carry through custom points from the score_out_of on instructor graded questions.
Set the points per question on selection statements where that is possible (all possible questions have the same non-default point value) so default pointsPerQuestion does not override custom points.
Note 2 is independent of 1 and is a general improvement for ALL pool selections, whether instructor graded or not.
This PR also takes the opportunity to remove the spurious scoringStrategy: "average" which was attached to parts in earlier versions of the code. This is not used by torus.