Conversation
rgachuhi
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy match patterns for numeric questions could include a math operator before the number, though use of these was fairly rare. E.g. match=">100" would match if number is greater than 100. Patterns of this form were not being handled by migration tool. This PR fixes migration tool to translate match patterns of this form into the appropriate torus rules.
There are a few examples in the legacy CS111 course at
https://svn.oli.cmu.edu/svn/content/editor/projects/echo-oli-cmu-edu/cs111-dnfwscpn/branches/v_2_8-echo