Conversation
added 2 commits
October 24, 2025 17:50
andersweinstein
changed the title
rgachuhi
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues for migrating popups of particular relevance to language courses:
If a popup contains only audio, instructors want it to require deliberate click to play. Default of hover causes audio to play on every mouseover which is undesired.
Also fixes an issue where a popup containing a "translation" element was not getting its content migrated. This happened in a case where the legacy "extra' element also contained a meaning element containing a dummy empty paragraph. Migration expects to find popup content in either "meaning" or "translation" (they both have same effect, the only difference is semantic tagging). It looks for a meaning first, so inclusion of a dummy empty paragraph here was pre-empting the content in the translation element. While this can be fixed in the sourceby deleting the dummy meaning, this PR enhances migration tool to ignore meaning in this case, so no source change is required.
This PR also adjusts use of an existing utility predicate now renamed
emptyOrDummyContentwhich apparently was not being called correctly when processing optional common prologue content in question pools. (Pool prologue content is included so rarely, this error apparently was never noticed).