Conversation
rgachuhi
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues in the migration of video elements that gave rise to problems in a migrated french course:
Mime type on element was hardcoded to video/mp4, even if video uses another format like video/webm. A mismatch is apparently harmless in Chrome, but caused playback to fail in Safari (https://eliterate.atlassian.net/browse/MER-5210) This corrects to infer from extension. (Note video's mime type was already being inferred correctly from extension when written into media manifest; this only affects contenttype specified in the video content element json.)
Legacy allowed a "poster" attribute on the video element to specify a poster image, an optional static image (usually a still frame) to be shown before video starts to play. Poster image URLs were not hit in the URL translation phase though the poster attribute passes through, leaving the migrated videos with bad legacy URLs (e.g. "../webcontent/myposter.jpg"), so that poster images fail to load. This corrects migration tool to translate URLs in video poster attributes.
While working on 2, also attempted some AI-assisted cleanup of the messy code that finds and translates URLs in DOM elements, mainly to be driven from a table of target element descriptors rather than lots of if-else cases.