Conversation
andersweinstein
changed the title
rgachuhi
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy command buttons could target iframes and also specify a list of {label, message} pairs to implement toggling behavior on click as for Play/Pause or Show/Hide buttons. This handles these features by translating to the forthcoming torus support for them (see #6241). For iframe targets, it sets the optional targetId parameter, always setting on migrated jmol applet frames. For toggling buttons, it fills in the optional toggleStates list. The conversion is backwards compatible, relying on optional attributes that will be ignored if unsupported. In particular, for toggle buttons the single message attribute continues to get filled in exactly as before with the first label and message so this fallback behavior is unchanged.
This also puts in a fix for the flattening of side-by-side materials which affecting the motivating course for this feature. Previously, these were only flattened if they contained activities; otherwise they migrate into tables. But iframes (as for the jmol applet) or for that matter media elements apparently cannot live in torus table cells, causing these to disappear in authoring (though they rendered in the more permissive author preview). The fix extends the flattening to side-by-side materials containing such elements.