Fix reading power limit on Nvidia GPUs#73
Open
artur-ag wants to merge 1 commit intoSimonFair:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some Nvidia GPUs, nvidia-smi does not report
power_limit, but rathercurrent_power_limit. I updated Nvidia.php to read both these fields, withcurrent_power_limitbeing given preference. This causes the powermax data field to always beN/A, and the power bar in the interface to never fill up. This PR fixes that.There was also a bug in the code where it checked for power_limit but then read current_power_limit. I fixed that too.
Sample nvidia-smi of an RTX 2080 Ti (gpu_power_readings section):