-
Notifications
You must be signed in to change notification settings - Fork 1
[MS-1290] Each credential match now produces a OneToOne event #1532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MS-1290] Each credential match now produces a OneToOne event #1532
Conversation
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
ybourgery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the timestamp are not the most accurate to represent what is actually happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
...va/com/simprints/feature/externalcredential/usecase/ExternalCredentialEventTrackerUseCase.kt
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Show resolved
Hide resolved
...com/simprints/feature/externalcredential/screens/search/ExternalCredentialSearchViewModel.kt
Outdated
Show resolved
Hide resolved
…hCandidatesUseCase to properly reflect the start and end time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
| MatchEntry(subjectId, confidence) | ||
| }, | ||
| fingerComparisonStrategy = if (match.isFaceMatch) null else getFingerprintComparisonStrategy(match.fingerprintBioSdk!!), | ||
| probeBiometricReferenceId = match.probeReferenceId.orEmpty(), |
Copilot
AI
Jan 14, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using orEmpty() on probeReferenceId silently converts null to an empty string. Consider whether an empty string is semantically correct for this field, or if null should be preserved or handled differently. If an empty string is intentional when the value is absent, this is acceptable.
| probeBiometricReferenceId = match.probeReferenceId.orEmpty(), | |
| probeBiometricReferenceId = match.probeReferenceId, |
|



JIRA ticket
Will be released in: 2025.4.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.4.0
There were no
OneToOneEventinstances for credential matches.Notable changes
Now, when a biometric probe that, linked to the credential, is being matched against a biometric probe taken during the workflow, a
OneToOnematch event is saved.Testing guidance
Awith a credentialCB, and use the same credentialCAdditional work checklist