Skip to content

Fix SQL Server authentication cert #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyf0x wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix SQL Server authentication cert #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d794b15
Add unit tests for SQL Server cert Date parameters
andyf0x Nov 10, 2025
65ba1ed
Use system date on certs to fix login auth issues
andyf0x Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions powershell/src/Public/Create-SqlServerCertificate.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ function Create-SqlServerCertificate{

[Parameter()]
[System.DateTimeOffset]
$NotBefore = [System.DateTimeOffset]::UtcNow,
$NotBefore = [System.DateTimeOffset]::Now,

[Parameter()]
[System.DateTimeOffset]
$NotAfter = [System.DateTimeOffset]::UtcNow.AddDays(3285)
$NotAfter = [System.DateTimeOffset]::Now.AddDays(3285)
)

Write-Information -MessageData "Creating a certificate for SqlServer with '$($SignerCertificate.Thumbprint)' signer." -InformationAction Continue
Expand Down
41 changes: 41 additions & 0 deletions powershell/test/Public/Create-SqlServerCertificate.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,46 @@
$certificate.Issuer | Should -Be $signerCert.Subject
}
}

Context 'When creating a self-signed certificate with DEFAULT validity period' {
It 'creates a certificate with the correct start and end dates' {
# Arrange
$commonName = 'test.sql.server'
$dnsName = 'test.sql.server'

# Act
$certificate = Create-SqlServerCertificate -CommonName $commonName -DnsName $dnsName -SignerCertificate $signerCert

# Assert
$certificate | Should -Not -BeNullOrEmpty

# Check default validity period
$now = [System.DateTimeOffset]::Now

$certificate.NotBefore | Should -BeGreaterThan ($now.DateTime.AddSeconds(-5))
$certificate.NotBefore | Should -BeLessThan ($now.DateTime.AddSeconds(5))

$certificate.NotAfter | Should -BeGreaterThan ($now.AddDays(3285).DateTime.AddSeconds(-5))
$certificate.NotAfter | Should -BeLessThan ($now.AddDays(3285).DateTime.AddSeconds(5))
}
}

Context 'When creating a self-signed certificate with CUSTOM validity period' {
It 'creates a certificate with the correct start and end dates' {
# Arrange
$commonName = 'test.sql.server'
$dnsName = 'test.sql.server'
$notBefore = [System.DateTimeOffset]::UtcNow.AddDays(-1)
$notAfter = [System.DateTimeOffset]::UtcNow.AddDays(365)

# Act
$certificate = Create-SqlServerCertificate -CommonName $commonName -DnsName $dnsName -SignerCertificate $signerCert -NotBefore $notBefore -NotAfter $notAfter

# Assert
$certificate | Should -Not -BeNullOrEmpty
$certificate.NotBefore | Should -BeGreaterThan ($notBefore.DateTime.AddSeconds(-1))
$certificate.NotAfter | Should -BeLessThan ($notAfter.DateTime.AddSeconds(1))
}
}
}
}