fixes calculation of beta from beta0 issue#62
Open
martinschwinzerl wants to merge 1 commit intoSixTrack:masterfrom
Open
fixes calculation of beta from beta0 issue#62martinschwinzerl wants to merge 1 commit intoSixTrack:masterfrom
martinschwinzerl wants to merge 1 commit intoSixTrack:masterfrom
Conversation
In the tracking maps for the spacecharge elements, beta has been calculated as beta = beta0 / rvv However, since rvv is defined as rvv = beta / beta0, beta = beta0 * rvv would be the correct way to calculate beta. This fixes inconsistencies between SixTrackLib >= 0.6 and pysixtrack
|
The argument is correct. For simplecticity reasons we should only use beta0, although is less accurate. |
|
Indeed, beta should disappear and we should use beta0 everywhere in the space charge lenses. As Riccardo says it is the only way of preserving symplecticity with a 4D lens. Moreover keeping beta does not really improve the accuracy: the interaction time depends on the beta of the particle but depends also on the path length (which in turn depends on px, py). These two effects fight against each other in typical cases (positive dispersion), therefore it does not really make much sense to keep one while neglecting the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the tracking maps for the spacecharge elements,
beta has been calculated as
beta = beta0 / rvv
However, since rvv is defined as rvv = beta / beta0,
beta = beta0 * rvv
would be the correct way to calculate beta. This fixes inconsistencies between
SixTrackLib >= 0.6 and pysixtrack