[Front] Ajout de packets de refresh et d'update#17
Open
dadodasyra wants to merge 8 commits intoSkeeww:masterfrom
Open
[Front] Ajout de packets de refresh et d'update#17dadodasyra wants to merge 8 commits intoSkeeww:masterfrom
dadodasyra wants to merge 8 commits intoSkeeww:masterfrom
Conversation
Ajout d'une action refresh et update envoyable depuis le socket serveur Refactor de quelques "var" (alors que let est préférable) /!\ Version non testé et nécessite test, notamment sur les 2 TODOs indiqués
Ajout d'une action refresh et update envoyable depuis le socket serveur Refactor de quelques "var" (alors que let est préférable) /!\ Version non testé et nécessite test, notamment sur les 2 TODOs indiqués
Update correctement la fonction getCanvasFromUrl ayant été modifié sur la branche mère
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout d'une action refresh et update envoyable depuis le socket serveur (Coté serveur non effectué mais facile d'usage)
Cette version n'update pas tout seul le code mais indique uniquement par le biais d'une notification qui ouvre une nouvelle page qu'il doit mettre à jour le client.
Refactor de quelques "var" (alors que let est préférable) + mise en forme de
getCanvasFromUrl/!\ Version non testé (car environnement de test compliqué à mettre en place) et nécessite des tests, notamment sur les 2 TODOs indiqués