feat: update settings page base theme selection logic#6
Open
zackspear wants to merge 1 commit intoSkitals:masterfrom
Open
feat: update settings page base theme selection logic#6zackspear wants to merge 1 commit intoSkitals:masterfrom
zackspear wants to merge 1 commit intoSkitals:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there - I'm a dev over @ Unraid.
I realize this repo has been untouched for quite a while but there are some CSS refactors coming down the pipeline in soon to be released Unraid 7.1.0 that changes the directory structure for the base webgui themes.
The new theme files are now setting CSS variables instead of being duplicated versions of the base CSS with different color values in each of them and ever so slight differences for Azure & Gray vs Black & White.
The changes in 7.1.0 generally work well with the theme engine plugin. However, the plugin settings page needs this update to pull the base themes from the new directory.
This PR introduces the changes to the settings page with a fallback to the legacy directory structure.