Skip to content

Put callback on an event from the file stream #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tforbus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Put callback on an event from the file stream #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ You can also clone this repository into your `node_modules` directory.
var snapito = require('screenshot');
var screenshot = new snapito('yourapikey');

screenshot.screenshot('http://www.google.com', 'google.png', {screen: 'desktop'}, function(file){
screenshot.screenshot('http://www.google.com', 'google.png', {screen: 'desktop'}).on('close', function(file){
if (file) {
console.log('The file ' + file + ' was written correctly');
} else {
Expand Down Expand Up @@ -49,8 +49,8 @@ call to Snapito. Here is a list of them:
var snapito = require('screenshot');
var screenshot = new snapito('yourapikey');

// screenshot.screenshot(url, file, options, callback)
screenshot.screenshot('http://www.google.com', 'google.png', {screen: 'desktop'}, function(file){
// screenshot.screenshot(url, file, options).on('event', callback)
screenshot.screenshot('http://www.google.com', 'google.png', {screen: 'desktop'}).on('close', function(file){
if (file) {
console.log('The file ' + file + ' was written correctly');
} else {
Expand Down
4 changes: 3 additions & 1 deletion screenshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ Screenshot.prototype.screenshot = function(url, file, options, callback) {
options += params_string;

// Send request
request(options).pipe(fs.createWriteStream(file));
var fileStream = fs.createWriteStream(file);
request(options).pipe(fileStream);
return fileStream
};

module.exports = Screenshot;