More precise crystal waypoints when clicking or killing NPCs (Odawa, …#1605
Open
TheMychenik wants to merge 7 commits intoSkyblockerMod:masterfrom
Open
More precise crystal waypoints when clicking or killing NPCs (Odawa, …#1605TheMychenik wants to merge 7 commits intoSkyblockerMod:masterfrom
TheMychenik wants to merge 7 commits intoSkyblockerMod:masterfrom
Conversation
…Corleone, etc.). Not working with Khazad-dûm (Bal), Fairy Grotto, Dragon's Lair, or Goblin Queen's Den. Maybe figure out how to handle these later.
viciscat
reviewed
Aug 24, 2025
| private final String name; | ||
| private final String linkedMessage; | ||
| private final @Nullable String name; | ||
| private final String npcName; |
Collaborator
There was a problem hiding this comment.
this field isn't only used for NPC names
Comment on lines
120
to
121
| BlockPos pos = CLIENT.player.getBlockPos(); | ||
| placeVerifiedWaypoint(waypointLocation, pos); |
Collaborator
There was a problem hiding this comment.
would using the npc's position be better?
Contributor
Author
|
@viciscat Yes, you're right, I think I'll just call it linkedText. About the position too, for some reason I didn't think about it. |
kevinthegreat1
requested changes
Sep 4, 2025
Collaborator
kevinthegreat1
left a comment
kevinthegreat1
left a comment
There was a problem hiding this comment.
I'll mark this as changes requested until commits are pushed addressing review issues.
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
Alex33856
added
merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most locations are detected by listening for NPC interactions (clicks). We also check that an existing waypoint isn't already nearby (I manually tuned the optimal searchRadius).
For Khazad-dûm, Goblin Queen’s Den, and Mines of Divan, we still rely on chat messages that announce obtaining the Crystal (same as before).
I profiled it and didn’t notice any impact on performance.